Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #94 added from clause to the exception statement in #143

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

dwmorris11
Copy link
Contributor

the call method of the Zure class to make it more informative

Issue #94

the __call__ method of the Zure class to make it more informative
Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d742154) 90.84% compared to head (c944af0) 90.84%.

Files Patch % Lines
semantic_router/llms/zure.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files          29       29           
  Lines        1322     1322           
=======================================
  Hits         1201     1201           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam
Copy link
Member

@dwmorris11 added another commit to keep conventional commits happy — but for any future PRs where you expect just on commit we need to name the commit with conventional commit syntax

  • it's an annoying rule to get the tests to pass, I will see if we can modify it

@jamescalam jamescalam changed the title bug: issue #94 added from clause to the exception statement in fix: issue #94 added from clause to the exception statement in Feb 11, 2024
@jamescalam jamescalam merged commit 43f9808 into aurelio-labs:main Feb 11, 2024
7 of 9 checks passed
@dwmorris11 dwmorris11 deleted the zure-exception branch February 11, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants